search

facebookresearch / Ego4d

Ego4d dataset repository. Download the dataset, visualize, extract features & example usage of the dataset
https://ego4d-data.org/docs/
MIT License
361 stars 49 forks source link

CLAP feature extraction code init #338

Open SAGNIKMJR opened 5 months ago

miguelmartin75 commented 5 months ago

Can you move scripts/CLAP_features/extract_features.py to ego4d/egoexo/scripts? i.e. git mv scripts/CLAP_features/extract_features.py ego4d/egoexo/scripts/extract_clap_features.py

Looks good, could be improved to distribute the extraction, but since you've already extracted the features then this doesn't matter.

Please delete the code I've flagged as unused (this is just noise when you read it). I've also comments as suggestions for future code you write (don't need to apply my suggestions other than delete unused code).

facebook-github-bot commented 4 months ago

@SAGNIKMJR has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.