search

facebookresearch / Pearl

A Production-ready Reinforcement Learning AI Agent Library brought by the Applied Reinforcement Learning team at Meta.
MIT License
2.68k stars 166 forks source link

Rename FIFOOffPolicyReplayBuffer to SARSAReplayBuffer in tutorials #104

Closed yepw closed 3 weeks ago

yepw commented 3 weeks ago

FIFOOffPolicyReplayBuffer was renamed to SARSAReplayBuffer in a recent commit c5c692d4a51da352bfc70b121fa3315f3134db13, but the tutorial is not updated.

facebook-github-bot commented 3 weeks ago

Hi @yepw!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 3 weeks ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

rodrigodesalvobraz commented 3 weeks ago

Thank you, this is very much appreciated!

facebook-github-bot commented 3 weeks ago

@rodrigodesalvobraz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 weeks ago

@rodrigodesalvobraz merged this pull request in facebookresearch/Pearl@ffdbc8a2ec4964f9b717cd4174f36139ab8c7b27.

rodrigodesalvobraz commented 3 weeks ago

@yepw , just so you know, it turns out your PR was incorrect and broke the tutorials. SARSAReplayBuffer replaced FIFOOnPolicyReplayBuffer, not FIFOOffPolicyReplayBuffer (the correct replacement for that was BasicReplayBuffer). Also, the tutorials need to be re-run when altered. Of course we share responsibility since we didn't notice the problem before accepting the PR! In any case, we have fixed that and re-run the tutorials, so that should be ok now. Thanks.

yepw commented 3 weeks ago

@rodrigodesalvobraz oooops, thank you for letting me know!