search

facebookresearch / PoseDiffusion

[ICCV 2023] PoseDiffusion: Solving Pose Estimation via Diffusion-aided Bundle Adjustment
Other
718 stars 42 forks source link

For Code Review #1

Closed jytime closed 1 year ago

jytime commented 1 year ago

Compare the version at Apr 4th to the original empty one.

jytime commented 1 year ago

Hi David @davnov134 ,

Apologies for only noticing the new comments today (somehow github does not send notifications to me). It seems that some of the issues raised are intermediate problems that occurred while I was debugging. We are still in the process of implementing and verifying GGS. My plan is to first complete the implementation of the dataset class and evaluation pipeline to establish a stable version. Afterward, I will address and clean up the code based on stable version, according to the comments provided. Because I guess we would see similar issues during the implementation of the dataset class and evaluation pipeline, and may be better to solve them together. Does this approach work for you?

Best, Jianyuan

jytime commented 1 year ago

Okay I quickly fix some of the comments above. They can be found at the commit "quick fix for pull request comments"