zxpmirror1994 commented 2 years ago

Summary: FX tracing is a pre-requisite of GMS. The current dense-only RL model is not FX traceable. In this diff the model is tweaked to enable FX tracing without any potential behavior change.

Differential Revision: D38835020

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D38835020

codecov-commenter commented 2 years ago

Codecov Report

Merging #674 (8ae98c0) into main (1fe8ba8) will increase coverage by 0.00%. The diff coverage is 95.00%.

@@           Coverage Diff           @@
##             main     #674   +/-   ##
=======================================
  Coverage   87.46%   87.47%           
=======================================
  Files         366      366           
  Lines       23351    23364   +13     
  Branches       44       44           
=======================================
+ Hits        20424    20437   +13     
  Misses       2901     2901           
  Partials       26       26

Impacted Files	Coverage Δ
reagent/core/types.py	`87.02% <88.88%> (+0.07%)`	:arrow_up:
reagent/models/critic.py	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

facebookresearch / ReAgent

Enable FX tracing on the dense-only RL model #674

Codecov Report