facebookresearch / ocean

Ocean is the in-house framework for Computer Vision (CV) and Augmented Reality (AR) applications at Meta. It is platform independent and is mainly implemented in C/C++.
https://facebookresearch.github.io/ocean/
MIT License
642 stars 58 forks source link

Windows build script fails for paths with spaces #11

Closed enpe closed 4 months ago

enpe commented 4 months ago

Following the build instructions from

https://github.com/facebookresearch/ocean/blob/main/building_for_windows.md

on a PC running Windows 11, the build fails immediately with the following error:

Microsoft Windows [Version 10.0.22631.3810]
(c) Microsoft Corporation. All rights reserved.

C:\Users\First Last>cd /D %OCEAN_DEVELOPMENT_PATH%

C:\Users\First Last\path\to\ocean>.\build\cmake\build_thirdparty_windows.bat -config debug -link static -build C:\build_otp -install C:\install_otp

C:\Users\First Last\path\to\ocean>echo off
BUILD_TYPE           Debug
BUILD_SHARED_LIBS    OFF
BUILD_DIRECTORY      C:\build_otp\windows_static_Debug
INSTALL_DIRECTORY    C:\install_otp\windows_static_Debug
'C:\Users\First' is not recognized as an internal or external command,
operable program or batch file.
Some builds have failed.
- windows_static_Debug

C:\Users\First Last\path\to\ocean>

This is probably fixed by adding quotes around paths, e.g. "C:\Users\First Last\path\to\ocean".

enpe commented 4 months ago

Should be fixed with

https://github.com/facebookresearch/ocean/commit/37e731927a01f99fccaea79adeac866210b4f5a9