search

facebookresearch / pytorch3d

PyTorch3D is FAIR's library of reusable components for deep learning with 3D data
https://pytorch3d.org/
Other
8.7k stars 1.3k forks source link

Fisheye Camera Typo and Overflow fix #1669

Open jcjackch opened 11 months ago

jcjackch commented 11 months ago

Typo fix

facebook-github-bot commented 11 months ago

Hi @jcjackch!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 11 months ago

@bottler has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 11 months ago

@jcjackch has updated the pull request. You must reimport the pull request before landing.

bottler commented 11 months ago

@jcjackch Do you want the epsilon stuff to be part of this PR? If so, might it be more efficient to use a boolean_mask like for th_divr? And also please update the PR title.