Fix windows build - Githubissues

facebookresearch / pytorch3d

PyTorch3D is FAIR's library of reusable components for deep learning with 3D data

https://pytorch3d.org/

Other

8.7k stars 1.3k forks source link

Closed eclipse0922 closed 9 months ago

eclipse0922 commented 10 months ago

Change the data type usage in the code to ensure cross-platform compatibility long -> int64_t

Tested under Win 11 and Ubuntu 22.04 with CUDA 12.1.1 torch 2.1.1

Related issues & PR

bottler commented 10 months ago

Thank you! This is indeed correct.

facebook-github-bot commented 10 months ago

@bottler has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

evenking1 commented 9 months ago

WX20231205-105802 我任然没编译通过，我的环境是win10+vs2022+python3.10.11+cuda12.1+torch2.1.1

eclipse0922 commented 9 months ago

@evenking1 Thanks for the test, I will check again.

evenking1 commented 9 months ago

@evenking1 Thanks for the test, I will check again.

"Thank you very much for getting back to me. I made some adjustments to my setup, and your method worked. The code compiled successfully. Thanks!"

facebook-github-bot commented 9 months ago

@bottler merged this pull request in facebookresearch/pytorch3d@7606854ff7d87b2b3ae99102d9868de57b88f9df.