search

facn6 / week5-Dana-Kira

0 stars 2 forks source link

Minimal project #54

Open shiryz opened 5 years ago

shiryz commented 5 years ago

A project that is 2 days long and the fact that you have some experience with node, I expected to see more... You need a richer readme, more handlers and at least better design... Your project is good I just expected more.

kira-abl commented 5 years ago

We don't understand the comment (apart from the design issue). We have a handler that works as five different handlers and requests five different sections from the Guardian API. It seems enough. How many handlers do we need? What do you mean? Could you explain?

shiryz commented 5 years ago

The concept of the project could be more complex, you could have done more things than just an api request with the section :rainbow:

samjam48 commented 5 years ago

see #56 for ideas on making it slightly more complex...