search

facultymatt / angular-unsavedChanges

angular-unsavedChanges
175 stars 81 forks source link

not working with bootstrap modal popup form #13

Open meulrajput opened 10 years ago

meulrajput commented 10 years ago

I have tried but its not working with form within modal. Can please tell me how can i set unsaved warning in modal.

TimonVS commented 9 years ago

I can confirm that the directive doesn't work within a modal.

cstephe commented 9 years ago

A modal by definition should have clear intent, with no use case path but to accept or cancel. This can be an issue with reloading and using the back buttons, but I think an argument can be made these actions are typically self confirming.

However, I'd like to hear the usecase where it's necessary, I'll probably run into it myself eventually.

Also the issue I've had with angular ui dialogs is that they isolate scope and append to body. This has many times caused incompatibility with some modules implementations that expect the dom elements to be in a spot, although I can't see where its happening in the source.

menelaosbgr commented 9 years ago

I think this is basically the same issue as the one I wrote previously: https://github.com/facultymatt/angular-unsavedChanges/issues/56