search

facultymatt / angular-unsavedChanges

angular-unsavedChanges
175 stars 81 forks source link

e2e tests now failing due to protractor/ selenium issue closing dialog boxee #25

Open facultymatt opened 10 years ago

facultymatt commented 10 years ago

see https://github.com/angular/protractor/issues/308 and https://github.com/angular/protractor/issues/1486

Used to work fine, now all tests that relate to window.onbeforeunload are broken.

awerlang commented 9 years ago

I think I do not need to care about unsaved-changes-warning in my e2e tests, that should be covered in another suite.

I think a module/service that could be mocked would be nice, instead of a plain confirm(). What do you think?