search

fadden / CiderPress2

Tool for working with Apple II and vintage Mac disk images and file archives.
https://ciderpress2.com/
Apache License 2.0
50 stars 7 forks source link

Not recognizing "Probable" files as embedded disk images #35

Closed fadden closed 1 month ago

fadden commented 1 month ago

The "Probable" (ProDOS-Bootable) project at github.com/a2-4am/probable stores a 140KB disk image in an 800KB ProDOS volume. It should be opened as a sub-image with a double-click in the GUI or via --depth=max, but currently isn't.

The HasDiskImageAttribs() function in FileIdentifier.cs is responsible for deciding if something might be a disk image, which it does narrowly, using a combination of file type and filename extension. Even if the extension is unknown, we should still recognize it as a disk if the size is exactly 143360 bytes, as that is very likely a 5.25" disk image. We also want to recognize $F1 is a possible disk image file type (we currently only accept BIN or NON).

@a2-4am

fadden commented 1 month ago

Fix available in https://github.com/fadden/CiderPress2/releases/tag/v1.0.5-dev2