Closed ennerf closed 1 year ago
Hey there! I've analyzed the changes in the pull request and here's a report for you:
In LabelledMarkerRendererTests.java
:
.setLineColor("0xEE00EE")
to .setLineColor("#EE00EE")
.setMarkerColor("0xEE00EE")
to .setMarkerColor("#EE00EE")
In DataSetStyleParserTest.java
:
assertEquals("-fx-fill: 0xffff00ff;", style)
to assertEquals("-fx-fill: #ffff00ff;", style)
.setStroke("0xEE00EE")
to .setStroke("#EE00EE")
.setFill("0xEE00EE")
to .setFill("#EE00EE")
In StyleBuilder.java
:
properties.put(key, String.format("0x%02x%02x%02x%02x", r & 0xFF, g & 0xFF, b & 0xFF, o & 0xFF))
to properties.put(key, String.format("#%02x%02x%02x%02x", r & 0xFF, g & 0xFF, b & 0xFF, o & 0xFF))
In LabelledMarkerSample.java
:
.setStroke("0xEE00EE")
to .setStroke("#EE00EE")
.setFill("0xEE00EE")
to .setFill("#EE00EE")
No suggestions for improvement were found.
No potential bugs were found.
No improvements were found.
I would rate the code as follows:
That's it for the report! Let me know if you need anything else. Have a great day! 😄
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
9508d3c
) 48.09% compared to head (15f88c3
) 48.17%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
No Duplication information