fair-acc / chart-fx

A scientific charting library focused on performance optimised real-time data visualisation at 25 Hz update rates for data sets with a few 10 thousand up to 5 million data points.
GNU Lesser General Public License v3.0
504 stars 93 forks source link

fixed css hex color prefix (see #527) #625

Closed ennerf closed 1 year ago

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

pr-explainer-bot[bot] commented 1 year ago

Pull Request Report

Hey there! I've analyzed the changes in the pull request and here's a report for you:

Changes

  1. In LabelledMarkerRendererTests.java:

    • Line 150: Changed .setLineColor("0xEE00EE") to .setLineColor("#EE00EE")
    • Line 151: Changed .setMarkerColor("0xEE00EE") to .setMarkerColor("#EE00EE")
  2. In DataSetStyleParserTest.java:

    • Line 39: Changed assertEquals("-fx-fill: 0xffff00ff;", style) to assertEquals("-fx-fill: #ffff00ff;", style)
    • Line 73: Changed .setStroke("0xEE00EE") to .setStroke("#EE00EE")
    • Line 74: Changed .setFill("0xEE00EE") to .setFill("#EE00EE")
  3. In StyleBuilder.java:

    • Line 68: Changed properties.put(key, String.format("0x%02x%02x%02x%02x", r & 0xFF, g & 0xFF, b & 0xFF, o & 0xFF)) to properties.put(key, String.format("#%02x%02x%02x%02x", r & 0xFF, g & 0xFF, b & 0xFF, o & 0xFF))
  4. In LabelledMarkerSample.java:

    • Line 59: Changed .setStroke("0xEE00EE") to .setStroke("#EE00EE")
    • Line 60: Changed .setFill("0xEE00EE") to .setFill("#EE00EE")

Suggestions

No suggestions for improvement were found.

Bugs

No potential bugs were found.

Improvements

No improvements were found.

Rating

I would rate the code as follows:

That's it for the report! Let me know if you need anything else. Have a great day! 😄

codecov[bot] commented 1 year ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9508d3c) 48.09% compared to head (15f88c3) 48.17%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #625 +/- ## ============================================ + Coverage 48.09% 48.17% +0.08% - Complexity 6213 6239 +26 ============================================ Files 374 374 Lines 38299 38390 +91 Branches 6110 6134 +24 ============================================ + Hits 18419 18494 +75 - Misses 18721 18734 +13 - Partials 1159 1162 +3 ``` | [Files](https://app.codecov.io/gh/fair-acc/chart-fx/pull/625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc) | Coverage Δ | | |---|---|---| | [...n/java/io/fair\_acc/dataset/utils/StyleBuilder.java](https://app.codecov.io/gh/fair-acc/chart-fx/pull/625?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc#diff-Y2hhcnRmeC1kYXRhc2V0L3NyYy9tYWluL2phdmEvaW8vZmFpcl9hY2MvZGF0YXNldC91dGlscy9TdHlsZUJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/fair-acc/chart-fx/pull/625/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=fair-acc)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.