Closed romanlutz closed 3 years ago
My main feedback would also be to rewrite some of the demo notebooks. I tried running it and it was an-unintuitive experience. Apperantly jupyter notebook
is supported but jupyter lab
isn't. It's also a bummer that I can't see the results from github. The fact that I had to download the notebook to see the effect of an algorithm is, to me, a big barrier of entry.
The demo notebooks currently requires you to learn two tools at once. A new algorithm and a new visualisation tool. If the visuals were simple matplotlib charts then a new developer would experience less cognitive load while trying to learn the new algorithm.
The demo notebooks currently requires you to learn two tools at once. A new algorithm and a new visualisation tool. If the visuals were simple matplotlib charts then a new developer would experience less cognitive load while trying to learn the new algorithm.
I think once we move away from having the widget code in the main repo, it'd make sense to use simple plots in the docs and have one or two examples with the widget to showcase the integration or something.
@romanlutz hello! I had written out comments on this, but ended up saying them in the developer call instead, and will hang back for a bit now.
If I can help move forward any work towards addressing practitioner needs (eg, Holstein et al. 2019), or help with unblocking other folks who want to work on that (whether in Azure ML or open source), please let me know!
To me this proposal is less clear than the one before.
There are a few aspects which need to be clearly defined here:
Moving the current UI out of the repo, and back into the microsoft org, with its defined development style/governance.
Whether or not we'd like to have a coordinated effort towards an alternative UI or set of dashboards.
The answer to the second question depends on how much time and effort and person/hour the community has to dedicate on the issue. There are two alternatives:
Fork the
microsoft/fairlearn-ui
repo intofairlearn
org, and continue development from that point, which will cause the two efforts diverging eventually. The plus side of this is that there's a place where everybody can collaborate. The downside is that there needs to be some sort of maintenance and a team who takes care of it.Let people/groups make their own repos/forks, and if any of them at some point starts being a good one (however we'd like to define good there, it's pretty vague), we could move it to the
fairlearn
org. The plus side is that it requires no centralized organizational support; and the down side is that it makes it harder for people to discover where they can contribute.I get the feeling that there are enough people who really care about having an independent and dynamic UI, and hence having a separate repo within
fairlearn
org makes sense. Having this repo, would also mean people in microsoft who work on the azure-ml UI, could contribute back to the open repo, or take community contributions back to azure-ml; if the two code-bases remain compatible enough.
@adrinjalali I can certainly rewrite it such that the proposal pretends the call didn't happen, but I felt like it's useful to add context on why there was confusion and how that affects the plans. To avoid having people comment on different underlying text I'll leave it as is for today but once people have a chance to give feedback I can adjust according to your feedback.
I'm curious what details you'd like to see about moving the UI. Happy to add more details or link to other places if it's too much for the proposal.
Figuring out the latter point is exactly what I'm trying to get at with the rewritten proposal (I suppose it's less of a proposal and more of a discussion of options now). This can only be answered if we know what commitments people are willing to make. So far Kevin was the only one who wanted to contribute, but that may very well have been due to the lack of openness. (Besides, there's an argument to be made for enabling the future of UI development and not only catering to present needs.)
Each of the outlined options has pros and cons and I'm perfectly happy with whatever people are comfortable with.
@romanlutz I don't think I have anything else to offer here, and I apologize if joining this conversation on the call or in GitHub has just resulted in noise and distraction. I'm sorry 😞
@adrinjalali @koaning @mbrouns @kevinrobinson @hildeweerts @chisingh @KeXu444 @chnldw Please share your thoughts :-) We'll bring this up in the developer call tomorrow as well.