fairtracks / fairtracks_standard

FAIRtracks is a JSON Schema defining a minimal standard for genomic track metadata.
https://fairtracks.net
Creative Commons Attribution 4.0 International
7 stars 2 forks source link

Sample schema refactor #20

Closed sveinugu closed 5 years ago

sveinugu commented 5 years ago

Refactored sample schema to allow for several variants of sample_types, dependent on the biospecimen_class property (renamed from biomaterial_type). Added ontology validation of biospecimen_class terms, and ancestor validation to all new properties.

sveinugu commented 5 years ago

Renamed property:

New properties:

Validation

sveinugu commented 5 years ago

Fixes: https://github.com/fairtracks/fairtracks_standard/issues/15

sveinugu commented 5 years ago

Referenced in https://github.com/orgs/fairtracks/teams/fairtracks-developers/discussions/20

jmfernandez commented 5 years ago

Hi @sveinugu , some of the functionality you are looking for is already implemented, with the key name of ancestors, as you can read in the documentation:

https://github.com/fairtracks/fairtracks_validator/blob/master/README.md

Could you open issues in FAIRTracks Validator repo describing the new features you are missing, please?

dzerbino commented 5 years ago

Looks good to me.

sveinugu commented 5 years ago

Force pushed a rebased and fixed commit