Open yusitnikov opened 2 months ago
Thanks for your PR. In view of the many open feature addition PRs and the huge backlog of maintenance tasks (e.g. releases, upstream merges) I unfortunately have to say though that I am currently fairly hesitant to add features that are quite specific to rare/exotic variants, so I will defer the decision on this PR for quite some time until maintainability is improved. I hope you understand.
The PR introduces a new chess variant - "sudoku chess". In a few words, it's normal chess, but player is not allowed to capture opponent's pieces while player's pieces break 8x8 sudoku rules (i.e. there are repeating pieces of the same type in a file, rank or 4x2 box). Full rules reference: https://gist.github.com/yusitnikov/e81a5e4df2fce6a854db8a2950fa5cfc
Benchmark results:
StateInfo
struct. I guess that it could be solved by allocating the memory dynamically only when the variant is enabled, but it will add complexity to the codebase. Is it worth optimizations?Compatibility: I personally plan using the variant only with classic setup: 8x8 board, standard initial position, normal chess rules + sudoku. But theoretically, there's nothing in the variant implementation that prevents using it with:
LARGEBOARDS
compilation option.Issues and potential improvements:
do_move
re-calculates the sudoku conflicts map from the scratch. It should be possible to optimize.Sorry for a large PR! It's the smallest possible chunk of changes that will have a value for the variant support.