search

faithfracture / Apple-Boost-BuildScript

Script for building Boost for Apple platforms (iOS, iOS Simulator, tvOS, tvOS Simulator, OS X)
279 stars 111 forks source link

Accepting pull requests? #46

Closed guillaumealgis closed 4 years ago

guillaumealgis commented 4 years ago

Hi,

I spent the last few days working on this script in our fork (https://github.com/ipsosante/Apple-Boost-BuildScript) to make it work for us. I'd be happy to upstream some of our fixes and improvements that would benefit more than just us, so I was wondering if you were accepting PR / had the time to review them?

Some of the changes are :

Let me know if you're interested and I'll send PR your way :)

faithfracture commented 4 years ago

Yes please that sounds great! I really only get around to maintaining this myself when we updated our Boost version, and we’ve been on 1.69 for a while now. Being quarantined and all right now, I’m finding myself with a little extra time, so now would be a great time to submit PRs :)

I would app appreciate it if you wouldn’t mind submitting them separately in case there’s things about one or another I’d like to dialog about.

Thanks!

guillaumealgis commented 4 years ago

I really only get around to maintaining this myself when we updated our Boost version

Same :)

I would app appreciate it if you wouldn’t mind submitting them separately in case there’s things about one or another I’d like to dialog about.

Sure, that's what I had in mind too. I'll get to it then!