search

faithfracture / Apple-Boost-BuildScript

Script for building Boost for Apple platforms (iOS, iOS Simulator, tvOS, tvOS Simulator, OS X)
279 stars 111 forks source link

Updates for armv7s support and locale support from iOS and iPhoneSimulator SDKs #6

Closed jpswensen closed 7 years ago

jpswensen commented 8 years ago

I didn't want to go to the hassle of making a fork and make a pull request, so here is a simple patch that adds support for the armv7s architecture also as well as adds the appropriate flags to get locale support using the XCode toolchain for iconv.

I only tested it on iOS (not tvOS or others), but the associated changes may be similar.

Finally, I had to follow the recommendation from the blog https://github.com/faithfracture/Apple-Boost-BuildScript and modify the darwin.jam file to change "-arch arm" to "-arch armv7". I am not quite sure why I had to do that to get everything to compile. armv7s_and_locale_support.diff.zip

faithfracture commented 8 years ago
  1. armv7s is only used on iPad 4 and iPhone 5, which are both fine with armv7 code. I, personally, am not going to target armv7s in anything I build, which is why I excluded it from this script. If you want to add armv7s, please make it a user-configurable option that is disabled by default (so you have to opt into it).
  2. Your indentation is inconsistent with the rest of the script. Keep you style consistent with the rest of the script.
  3. I don't want to merge in changes to the BOOST_LIBS variable. I use this script for my projects and I don't want to have to change it every time I want to use it.
  4. The link you posted referencing the blog is a link to this script, not to a blog post.
faithfracture commented 7 years ago

Closing due to inactivity.