faker-ruby / faker

A library for generating fake data such as names, addresses, and phone numbers.
MIT License
11.28k stars 3.18k forks source link

Add Japanese translations for `Faker::Sports::Football`. #2903

Closed yamat47 closed 6 months ago

yamat47 commented 9 months ago

Motivation / Background

This Pull Request is created to add new locale data for Japanese football teams, players, coaches, competition names, and positions to this library.

Additional information

This change is based on existing English data, translated by contributors who are native Japanese speakers.

To ensure the accuracy and quality of the translation, it has been reviewed by multiple native speakers knowledgeable in soccer.

Checklist

Before submitting the PR make sure the following are checked:

If you're proposing a new generator or locale:

thdaraujo commented 7 months ago

hi @yamat47, could you reformat lib/locales/ja/football.yml so I can merge this?

Thanks!

yamat47 commented 6 months ago

@thdaraujo Thank you for the review.

I've added automated tests that pass locally but are failing on CI, and I'm looking into why. I used the same style as the rest of the project for RuboCop and am unclear why it's failing. Any specifics you could provide would be helpful.

Please let me know if you have any advice on how to proceed. Thank you!