faker-ruby / faker

A library for generating fake data such as names, addresses, and phone numbers.
MIT License
11.28k stars 3.18k forks source link

Add `hand_tool` to construction #2974

Closed jimgraham closed 4 months ago

jimgraham commented 5 months ago

Motivation / Background

This Pull Request has been created because I was attempting to backfill hand tools, and found them missing from Faker::Construction. I have added a random set of hand tools to the en locale.

I have reformatted the en locale via

➜  faker git:(main) ✗ bundle exec rake 'reformat_yaml[lib/locales/en/construction.yml]'
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
Reformatting /Users/jim/src/github.com/jimgraham/faker/lib/locales/en/construction.yml

to get the - syntax.

I've added documentation for this new method, and removed the "available in future versions" warning that does not apply

Checklist

Before submitting the PR make sure the following are checked:

thdaraujo commented 4 months ago

Thanks for your interest in contributing to faker, @jimgraham !

Currently we no longer accept completely new generators, at least for the time being.

Please take a look at the list of acceptable contributions: https://github.com/faker-ruby/faker/blob/main/CONTRIBUTING.md#what-contributions-we-are-looking-for