fal-ai / fal

⚡ Fastest way to serve open source ML models to millions
https://fal.ai/docs
Apache License 2.0
509 stars 44 forks source link

ui: reduce traceback to user code for user exceptions #140

Closed efiop closed 5 months ago

efiop commented 5 months ago

It is surprising and confusing for users to see our code in their tracebacks if their function raised some exception, we should hide that during normal operations.

The way isolate and fal currently work we would need to just litteraly walk through the traceback and remove stuff that is not from the user code, but I'm also considering maybe changing the logic in isolate's load_serialized_object to not raise but instead return something that could both cover a return value and an exception, so that we can later decide how to handle it and have nice original traceback to work with.

This is relevant for both api and cli.

linear[bot] commented 5 months ago

FEA-2184 reduce traceback to user code for user exceptions