falcosecurity / event-generator

Generate a variety of suspect actions that are detected by Falco rulesets
Apache License 2.0
95 stars 40 forks source link

Fix: In ExecutionFromDevShm we should use os.Mkdir("/dev") instead if os.Mkdir("/dev/shm") #208

Closed GLVSKiriti closed 7 months ago

GLVSKiriti commented 7 months ago

@FedeDP @leogr As os.Mkdir("/dev/shm") returns error as /dev not exists so instead we should use os.Mkdir("/dev") which just create /dev. And /dev/shm created in the next lines of code

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

poiana commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GLVSKiriti, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/event-generator/blob/main/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 7 months ago

LGTM label has been added.

Git tree hash: 1fbc06651e49d87dd19d36a9ff59784d8bab4b08