search

falcosecurity / plugin-sdk-go

Falco plugins SDK for Go
Apache License 2.0
26 stars 17 forks source link

update: set default required api version #41

Closed jasondellaluce closed 2 years ago

jasondellaluce commented 2 years ago

Signed-off-by: Jason Dellaluce jasondellaluce@gmail.com

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area plugin-sdk

What this PR does / why we need it:

This supports a default value for plugin_required_api_version that removes the requirement of setting the RequiredAPIVersion info field for plugin developers. The value can still be specified to override the default one. The default value is grabbed from plugin_info.h.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update: set default required api version
poiana commented 2 years ago

LGTM label has been added.

Git tree hash: e848c6767c9ed876316992419f61ff7ed6d6d0da

leogr commented 2 years ago

/approve

poiana commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugin-sdk-go/blob/main/OWNERS)~~ [jasondellaluce,leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment