fix(wrappers): properly reverse if check in async extractor

falcosecurity / plugin-sdk-go

Falco plugins SDK for Go

Apache License 2.0

26 stars 17 forks source link

fix(wrappers): properly reverse if check in async extractor #6

Closed FedeDP closed 3 years ago

FedeDP commented 3 years ago

Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
Co-authored-by: Jason Dellaluce <jasondellaluce@gmail.com>
Co-authored-by: Leonardo Grasso <me@leonardograsso.com>

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugin-sdk

What this PR does / why we need it:

Fixes ParamTypeUint64 switch case in RegisterAsyncExtractors to properly set the field_present bool and res_u64 value when present is true.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixes uint64 usage in async extractor.

poiana commented 3 years ago

Welcome @FedeDP! It looks like this is your first PR to falcosecurity/plugin-sdk-go 🎉

poiana commented 3 years ago

Hi @FedeDP. Thanks for your PR.

I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

FedeDP commented 3 years ago

On a side note: is there a reason why RegisterAsyncExtractors actually has a default switch case, and it also checks that strExtractorFunc and u64ExtractorFunc are not nil, while WrapExtractFuncs does not?
I wanted to extract a small function there, but i was worried that it could break something given this small detail.

leogr commented 3 years ago

/ok-to-test

poiana commented 3 years ago

LGTM label has been added.

Git tree hash: 1f32c8f8b0af20697f182f5dfeb70a335a9b21b7

poiana commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, mstemm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugin-sdk-go/blob/main/OWNERS)~~ [mstemm] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment