Closed therealbobo closed 1 year ago
Welcome @therealbobo! It looks like this is your first PR to falcosecurity/plugin-sdk-go 🎉
Hi @therealbobo. Thanks for your PR.
I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/hold
I was thinking that could be a good idea to add some helpers: that way the final user will use directly, for example, net.IP
instead of populating the buffer manually. WDYT? @jasondellaluce
/unhold
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce, therealbobo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area plugin-sdk
/area tests
What this PR does / why we need it:
This adds support for the main types described in the issue below.
Which issue(s) this PR fixes:
Umbrella: Adding support for new field types in plugins
Special notes for your reviewer:
This is still a WIP: it will need a lot of improvements for performance and clean up for sure!
Does this PR introduce a user-facing change?: