falcosecurity / plugin-sdk-go

Falco plugins SDK for Go
Apache License 2.0
26 stars 17 forks source link

new: Support for new field types in plugins #71

Closed therealbobo closed 1 year ago

therealbobo commented 1 year ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area plugin-sdk

/area tests

What this PR does / why we need it:

This adds support for the main types described in the issue below.

Which issue(s) this PR fixes:

Umbrella: Adding support for new field types in plugins

Special notes for your reviewer:

This is still a WIP: it will need a lot of improvements for performance and clean up for sure!

Does this PR introduce a user-facing change?:

action required: update plugins to use new sdk version
action required: add the new plugin types in libs
poiana commented 1 year ago

Welcome @therealbobo! It looks like this is your first PR to falcosecurity/plugin-sdk-go 🎉

poiana commented 1 year ago

Hi @therealbobo. Thanks for your PR.

I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
therealbobo commented 1 year ago

/hold

therealbobo commented 1 year ago

I was thinking that could be a good idea to add some helpers: that way the final user will use directly, for example, net.IP instead of populating the buffer manually. WDYT? @jasondellaluce /unhold

poiana commented 1 year ago

LGTM label has been added.

Git tree hash: 1c4eca83174d1450d30a9a45a77b08ca2119155d

poiana commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasondellaluce, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugin-sdk-go/blob/main/OWNERS)~~ [jasondellaluce] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment