search

falcosecurity / plugin-sdk-go

Falco plugins SDK for Go
Apache License 2.0
26 stars 17 forks source link

cleanup: add some comments and rename vars in SetRequiredAPIVersion #79

Closed Andreagit97 closed 1 year ago

Andreagit97 commented 1 year ago

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area plugin-sdk

/area tests

What this PR does / why we need it:

This PR adds some comments and tests to the SetRequiredAPIVersion logic. The plugin-required version should always be lower or equal to the SDK-required version.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
poiana commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, jasondellaluce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/plugin-sdk-go/blob/main/OWNERS)~~ [jasondellaluce] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 1 year ago

LGTM label has been added.

Git tree hash: 55df377c5800b97f0346ab8e430f3e60a68a423d