fancyapps / ui

A library of JavaScript UI components, includes the best lightbox - Fancybox5
https://fancyapps.com/
Other
794 stars 97 forks source link

"Nested" Fancybox instance ignores "inline" type, using "clone" instead. #670

Open max-novikov opened 3 months ago

max-novikov commented 3 months ago

Describe the bug

While trying to open another Fancybox, based on div from html loaded through ajax fancybox, for some reason "inline" type is ignored, and new instance is created as clone. Note that this was not the issue with the v4.

Reproduction

  1. Open some html through Fancybox ajax type. Html in question should contain an element with id attribute and display: none as style.
  2. Programmatically open another Fancybox with src set to the element from step 1 and inline as type.
  3. Instead of showing div in question, Fancybox creates a clone.

test.html attached test.html.txt Code to run: Fancybox.show([{'src': 'test.html','type': 'ajax'}]); Fancybox.show([{'src': '#sample','type': 'inline'}]);

Additional context

I've tried to upgrade Fancybox from v4 to v5 on my app, and while everything else works after some options rearrangements, the problem described above drives me nuts, as now I need to rewrite lots of markup to escape double-ids.

fancyapps commented 3 months ago

Hi,

This is designed to avoid problems when content is moved between Fancybox instances.