fancycode / pylzma

Python bindings for the LZMA library
http://www.joachim-bauch.de/projects/pylzma/
GNU Lesser General Public License v2.1
234 stars 72 forks source link

Installation fails via `pip3` on python 3. #18

Closed fake-name closed 10 years ago

fake-name commented 10 years ago

From reading your blog, apparently there is python 3 support /somewhere/, but it's not present in the egg available via pip.

I installed the package fine by manually git-cloning and running setup.py, so it looks like the eggs on Pypy just need to be updated. They appear to have been last touched in 2011, so three years ago.

fancycode commented 10 years ago

Yes, support for Python3 is not available in the latest released version. I'll try to tag a release sometime the next days and upload it to PyPI.

fake-name commented 10 years ago

Cool! That makes my install scripts a lot simpler.

fancycode commented 10 years ago

New version available on PyPI: https://pypi.python.org/pypi/pylzma

fake-name commented 10 years ago

This is not fixed. See travis-ci build-logs here:

Downloading/unpacking pylzma (from UniversalArchiveInterface==0.0.1)
  Downloading pylzma-0.4.5.tar.gz (109kB): 109kB downloaded
  Running setup.py (path:/home/travis/virtualenv/python3.4.2/build/pylzma/setup.py) egg_info for package pylzma
    Traceback (most recent call last):
      File "<string>", line 17, in <module>
      File "/home/travis/virtualenv/python3.4.2/build/pylzma/setup.py", line 144, in <module>
        version = get_git_version().decode('utf-8'),
    AttributeError: 'str' object has no attribute 'decode'
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
  File "<string>", line 17, in <module>
  File "/home/travis/virtualenv/python3.4.2/build/pylzma/setup.py", line 144, in <module>
    version = get_git_version().decode('utf-8'),
AttributeError: 'str' object has no attribute 'decode'
----------------------------------------
Cleaning up...
Command python setup.py egg_info failed with error code 1 in /home/travis/virtualenv/python3.4.2/build/pylzma
Storing debug log for failure in /home/travis/.pip/pip.log
The command "pip install ." failed and exited with 1 during .

pip install pylzma fails. pip install git+https://github.com/fancycode/pylzma does not. It appears the version that was uploaded to pip was not the current one?

Successful build by pulling directly from git here.

fancycode commented 10 years ago

This should be fixed with latest master, could you somehow test a source tarball from current master (create using python setup.py sdist)? If you confirm it's working, I will create a new release and upload to PyPI.

fake-name commented 10 years ago

I packed up a current tarball, and stuck it in my project's repo, and it also failed.

At this point, I'm thoroughly confused.


I'm not doing something horridly stupid, like building the wrong branch, am I? I'm just using the master branch.

Edit: Running a passing build (git+https) with --verbose here.

fancycode commented 10 years ago

No, looks like I missed some case in the Python 3 case. Should hopefully be fixed now...

fake-name commented 10 years ago

Testing now, one minute.

fake-name commented 10 years ago

Yep, that fixed it.

Should I close, or do you want to when the new package is up on Pypi?

fancycode commented 10 years ago

Great, thanks for testing! I'll close the issue when I release the new version. Should hopefully be sometime tomorrow.

fake-name commented 10 years ago

Cool. I'm just glad to have an excuse to play with TravisCI.

fancycode commented 10 years ago

Released as 0.4.6: https://pypi.python.org/pypi/pylzma