search

faradayio / cage

Develop and deploy complex Docker applications
http://cage.faraday.io
Apache License 2.0
307 stars 26 forks source link

Hide warnings from compose_yml validations #88

Closed camjackson closed 6 years ago

camjackson commented 6 years ago

Continuing the discussion from emk/compose_yml#11 a couple of months ago...

At this point it seems like the underlying libraries are unlikely to be updated by their original maintainers. Obviously it would be better to get the validations working again in compose_yml, but in the meantime Cage is left with a lot of unpleasant noise in the console on every command.

Would you be ok with hiding these warnings from Cage users?

emk commented 6 years ago

Yeah, I suppose we should.

Sorry for the long lag times on cage stuff—I had a minor operation recently, and between that and urgent work projects, I've been a bit squeezed.

Please never hesitate to make a big list of all the stuff you want reviewed and merged, and then forward it to me. :-)

camjackson commented 6 years ago

Bummer, hope your recovery is swift! No worries about the lag. Open source is hard work 🙂

camjackson commented 6 years ago

Hey @emk, any blockers to merging this and releasing? I've been spruiking cage to a bunch of people lately, and they tend to ask about all the console warnings!

emk commented 6 years ago

Let's do this. If you don't hear from me in the next few days, please ping me mercilessly until I relent and get my act together. :-)

camjackson commented 6 years ago

Great! Will do!

On Sun, 13 May 2018 at 09:54, Eric Kidd notifications@github.com wrote:

Let's do this. If you don't hear from me in the next few days, please ping me mercilessly until I relent and get my act together. :-)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/faradayio/cage/pull/88#issuecomment-388595404, or mute the thread https://github.com/notifications/unsubscribe-auth/AB10041OZ0z0mJ1-m-H_J0vnl6n6cwRJks5tx5JqgaJpZM4SHCKk .

jamesabc commented 6 years ago

@emk Ping 😅

camjackson commented 6 years ago

@emk Ping! :)

emk commented 6 years ago

Ack! And merged.

Sorry, another crazy busy week. :-/ Let me go make a release, and my apologies for the long delay for such a simple patch. Please let me know if you have anything else in the queue.

camjackson commented 6 years ago

Awesome! No need to apologise, we got there in the end :)