farice9 / pe

0 stars 0 forks source link

Flaws with user initialization (name and gender) input checking #1

Open farice9 opened 4 years ago

farice9 commented 4 years ago

image.png

It will be better if the program confirms the name first (loop back to ensure correct name) before proceeding to ask gender so that user don't have to retype both values if one of them is wrong (shown below)

image.png (User retypes both value when only gender is wrong)

image.png (User retypes both value when only name is wrong)

The name also accepts solely number, which might be better if it checks that it has both alphabets and number:

image.png

nus-pe-bot commented 4 years ago

Team's Response

Hello,

Thanks for your feedback.

This sounds like a feature suggestion to me. As the name and gender are required for making the user, the validation happens after instead of during input (which is handled by Ui). I think the difference between checking after name input or after gender is negligible as its just a difference of 4-6 characters which the user is unlikely to provide wrongly (as we already output the expected Gender of Male/Female/Other and accept case insensitive). Also, since user creation is only done once (and saved after), there is little difference.

Regarding the acceptance of numbers as name, we did so as we do not wish to implore strict naming conventions to our users. The name is mainly used for just greeting the user when he enters the application anyway, hence nothing important which warrants an 'official' name. Also, interesting fact is some people can have only numbers as their names in real life. Based on that, we decided to keep naming policy lenient.

Regards,

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]