search

farice9 / pe

0 stars 0 forks source link

Condition for looping should be placed closer to "loop" in sequence diagram #12

Open farice9 opened 4 years ago

farice9 commented 4 years ago

image.png

The condition [ui.hasNextLine()] should be placed closer to the "loop" box to avoid confusion.

nus-pe-bot commented 4 years ago

Team's Response

Thank you for the bug report, I believe the position of the condition is fine as its contained within a square bracket, to imply the condition of the loop. Additionally, the other conditions are located far away from this main loop logic, thus it will not be easily mistaken.

Evidence of no other conditions nearby:

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]