search

farooqkz / chooj

Matrix chat app for KaiOS feature phones supporting voice calls
74 stars 13 forks source link

Fix audio/voice message view #93

Closed plan5 closed 1 year ago

plan5 commented 1 year ago

This PR fixes https://github.com/farooqkz/chooj/issues/90

This was tested on Nokia 8000 (20.00.17.01) and Nokia 8118 4G (17.00.17.01).

The IRCLikeMessageItem.tsx set a faulty url to the audio file, which caused errors.

After fixing this, all audio messages would start playing immediately once they had been downloaded.

This could be fixed by removing the autoPlay attribute from the audio tag in the Item. Autoplay is off by default but it was enabled because the "false" part after the attribute wasn't compiled as a string.

plan5 commented 1 year ago

Wait, there is an error in the PR, sorry.

plan5 commented 1 year ago

I was mistaken :D

The PR works.

farooqkz commented 1 year ago

@plan5 Each PR should do exactly one thing. It seems you have mixed your 2 PRs.

plan5 commented 1 year ago

Ah, I see what you mean. I accidentally dragged in the background color commit - that wasn't intentional. I'll create a new PR.