Real IP Passing To hlswatch

faryon93 / hlswatch

keep track of hls viewer stats

GNU General Public License v3.0

49 stars 9 forks source link

Real IP Passing To hlswatch #11

Open aminhusni opened 5 years ago

aminhusni commented 5 years ago

Fixed on Issue #10 where the Nginx proxy is not passing real IP to hlswatch. This is fixed by making Nginx attach the original requester's IP to the X headers. hlswatch then read these headers and extract the real IP.

Fixed on docker build problem #7

faryon93 commented 5 years ago

Hi Amin, thank you for your pull request and your awesome work. da9028d and 9a9eb47 should be merged to master as soon as possible.

Im not sure about excluding private IPs.

aminhusni commented 5 years ago

The idea of excluding private IP was because the client might forward private IP in the chain of proxies that the client itself is using.

Perhaps it is a good idea to have an enable and disable the option that is read from the config file to filter out private IP?