fasheng / elfeed-protocol

Provide extra protocols to make like Fever, NewsBlur, Nextcloud/ownCloud News and Tiny Tiny RSS work with elfeed
GNU General Public License v3.0
97 stars 18 forks source link

Add `:password-eval` auth mechanism. #11

Closed ieure closed 5 years ago

ieure commented 5 years ago

The existing :password mechanism isn’t well-suited to fetching a password from an external store.

The :password-eval mechanism addresses these issues. Evaluation of the form given to :password-eval is deferred until it’s required, and the cleartext value is not persisted. It works equally well for shell-command-to-string invocations, secrets-get-secret, password-store-get, etc.

I also though about changing the existing :password to notice if the value was evalable (ex. (or (functionp f) (and (listp f) (functionp (car f))))), but settled on having an explicit key to get the behavior. I could go that direction if you feel strongly that it’s better than :password-eval.

fasheng commented 5 years ago

Thanks for the advice and high quality PR.

I agree with your second choice, please append one more commit to merge :password-eval to :password and add descriptions to show the feature, so we could hide the details and provide less choice for users. After all, this is not commonly used.

Thanks~

ieure commented 5 years ago

You got it.

fasheng commented 5 years ago

Great, merged and thanks~

ieure commented 5 years ago

You're very welcome. Thank for making this in the first place, it was a big missing piece in my RSS setup.