search

fasterthanlime / jsmad

:saxophone: Javascript MPEG-1 Audio Layer III (mp3) and ID3v2 decoder
http://audiocogs.org/codecs/mp3/
762 stars 41 forks source link

Fix errors raised by GSC and UglifyJS, and include a uglified version of the source code. #22

Closed romac closed 13 years ago

romac commented 13 years ago

O hai !

I was kinda bored tonight so I spent a couple hours trying to generate a minified version of jsmad (because you know, some folks around there say it's better to load one file than several ones).

I started using the Google Closure Compiler API (http://code.google.com/closure/compiler/docs/api-tutorial2.html) but this drunk bastard raised 50+ errors and refused to minify any code at all. UglifyJS raised some of its own as well so I had no choice but to fix these 'errors' in order to generate this damn jsmad.min.js file and here is the result. This pull request also includes a Node.js script which automate this last step.

Not sure if any of this is useful as the website is not experiencing that much traffic these days but, anyway, I had some fun. Which is the only thing that matters here :)

Cheers, mate !

nddrylliog commented 13 years ago

By the way, decoder.js is useless and should be deleted.

romac commented 13 years ago

@nddrylliog: I thought so but I wasn't sure why it was still there so I've left it ~ as is.

nddrylliog commented 13 years ago

Yes, that was the careful thing to do. You couldn't be sure, that's why I'm telling you now :)

On Mon, Aug 22, 2011 at 5:45 PM, romac < reply@reply.github.com>wrote:

@nddrylliog: I thought so but I wasn't sure why it was still there so I've left it ~ as is.

Reply to this email directly or view it on GitHub: https://github.com/nddrylliog/jsmad/pull/22#issuecomment-1871308

Amos Wenger Crafting the future of Web Audio at ofmlabs.org I'm @nddrylliog https://github.com/nddrylliog on GitHub