fastify / fastify-dx

Archived
903 stars 43 forks source link

Vue-router named route not working #55

Open toshoajibade opened 1 year ago

toshoajibade commented 1 year ago

Prerequisites

Fastify version

4.11.0

Plugin version

0.1.0

Node.js version

16.3.1

Operating system

Linux

Operating system version (i.e. 20.04, 11.3, 10)

MacOS Ventura 13.1

Description

Navigating using vue-router named route is not working both during programmatic navigation and when using RouterLink component. This is because the name of the route is not passed when creating the routes here, https://github.com/fastify/fastify-dx/blob/main/packages/fastify-vue/virtual/routes.js#L33.

To fix, I will suggest adding name: routeDef.name here.

I can open a PR for this.

Steps to Reproduce

Expected Behavior

The application should navigate to a new route

galvez commented 1 year ago

That would be highly appreciated — the routing system needs some touches.

toshoajibade commented 1 year ago

I will do that. Thanks for the amazing work. This package has been a life saver for a project I am working on. 🙏