Check if a tester is already added to the desired group(s)

phaseOne commented 7 years ago

Right now, boarding will display an error message if a tester is already added to an app, but not part of a group yet. In addition, invites are not resent, if the tester is already added to the group.

This PR is a work in progress to resolve these issues.

Tasks

[ ] Display the new and old groups to which a tester is added
[ ] Resend the TestFlight invite if the user has not yet accepted the invite, and display a message
[ ] Optimization: only add the tester to groups that the tester is not yet a part of

Addresses

180 Email Address Already Registered for New Users + No TestFlight Emails Sent
146 Email address already registered
88 Show error if user has already been added
147 No E-mails sent out

kdawgwilk commented 7 years ago

I thought I had posted on the other issue that I tested things out but it appears I forgot to send it :( But this PR looks like it will solve the only issue I was experiencing (pretty minor). The issue was with existing users not belonging to the group they are trying to be added to. Thanks for the hard work to get this fixed 👍

joshdholtz commented 6 years ago

@phaseOne This PR sounds like it would be a great addition. Are you still working on this? 🙃

FinHorsley commented 5 years ago

Please can the merge conflicts be resolved, and this PR accepted, as this solves the same problems that we have been seeing

phaseOne commented 5 years ago

Anyone else able to take this on? Slammed at the office right now

FinHorsley commented 5 years ago

@phaseOne Apart from the merge conflict, is there anything else that is preventing this PR from being accepted?

fastlane / boarding

Check if a tester is already added to the desired group(s) #188

Tasks

Addresses

180 Email Address Already Registered for New Users + No TestFlight Emails Sent

146 Email address already registered

88 Show error if user has already been added

147 No E-mails sent out