Issue-22329 fix update_code_signing_settings for projects saved with Xcode 16

Speakus commented 1 month ago

== fix update_code_signing_settings for projects saved with Xcode 16

If you open any project with Xcode 16 then TargetAttributes key will be removed from pbxproj (if it has empty array)

So this PR solving this issue: https://github.com/fastlane/fastlane/issues/22329

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass NB: one test was failed

1) Gym detects the correct platform for a visionOS project
 Failure/Error: expect(Gym.project.visionos?).to eq(true)

   expected: true
        got: false

   (compared using ==)

   Diff:
   @@ -1 +1 @@
   -true
   +false

 # ./gym/spec/platform_detection_spec.rb:33:in `block (2 levels) in <top (required)>'

But I have checked master branch have the sane issue

[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.
[x] I've added or updated relevant unit tests.

Motivation and Context

Resolves: #22329

Description

Now fastlane check about too old project written properly - and Xcode 16 saved project is not handled as too old project

Testing Steps

if pbxproj saved wit hxcode 16 please ensure the update_code_signing_settings command will fail (issue https://github.com/fastlane/fastlane/issues/22329 could be reproduced
then checkout the new branch and ensure the issue is gone

IsaiahJTurner commented 1 month ago

Would love to have this merged in. Would be helpful for our team

xiushaomin commented 1 month ago

hello, when the pull request will merge?

Speakus commented 3 weeks ago

Guys, review is still required. Any chance to get the review for PR?

fastlane / fastlane