Closed rasberik closed 1 month ago
bundle exec rspec
bundle exec rubocop -a
ci/circleci
Im not sure if whether this will cause regression in other tools & scenarios, dont have a high hope
Resolves https://github.com/fastlane/fastlane/issues/22324
After recent changes to enable enterprise API, we are noticing regressions in match when using app_store_connect_api_key for enterprise.
app_store_connect_api_key
undefined method `in_house?' for nil
For enterprise, match for enterprise with app_store_connect_api_key
sync_code_signing( git_branch: *_my_branch_*, team_id: *my_team_id_*, template_name: *my_template_name_*, type: 'enterprise', api_key: app_store_connect_api_key, app_identifier: *my_app_identitifers_*, )
Required Env:
APP_STORE_CONNECT_API_KEY_KEY APP_STORE_CONNECT_API_KEY_KEY_ID (*) APP_STORE_CONNECT_API_KEY_IS_KEY_CONTENT_BASE64 APP_STORE_CONNECT_API_KEY_ISSUER_ID APP_STORE_CONNECT_API_KEY_IN_HOUSE
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Im not sure if whether this will cause regression in other tools & scenarios, dont have a high hope
Description
Resolves https://github.com/fastlane/fastlane/issues/22324
After recent changes to enable enterprise API, we are noticing regressions in match when using
app_store_connect_api_key
for enterprise.Testing Steps
For enterprise, match for enterprise with
app_store_connect_api_key
Required Env: