🔑Add Android device frames

fastlane / frameit-frames

Hosting the latest frameit frames via GitHub Pages

https://fastlane.tools

95 stars 38 forks source link

🔑Add Android device frames #10

Closed milhauscz closed 4 years ago

milhauscz commented 5 years ago

🔑This PR adds Android device frames. A related PR adding Android support for frameit will be created in the fastlane repo.

janpio commented 5 years ago

Did you create this manually or was this done via a change to https://github.com/fastlane/fastlane/tree/master/frameit/frames_generator?

What's going on with the deleted iOS files in latest? That's not really expected, is it?

milhauscz commented 5 years ago

This was created automatically via frames_generator. The files were not deleted, only modified and have a few bytes less, maybe because the frames were updated in Facebook. The related PR can be found here.

janpio commented 5 years ago

You are of course correct, I misread the diff.

The height difference (which is the reason behind the smaller file size) is strange though: We will have to figure out where this is coming from, because before we had problem with this messing with people's screenshots.

I also see some new iOS devices which is kind of unexpected: We will at least have to understand why this happens right now. Did FB add these? Or did we have another change to the generator and hadn't recreated the frames yet?

milhauscz commented 5 years ago

I have made some changes in the frames_generator, but they should not touch the resulting pictures at all. I only modified these parts:

adding Android colors
sanitizing file names (some Android devices contained dash between name and color)
filtering the files so that Android devices are also included
detecting the offsets, because Samsung Galaxy S9's screen contained shadows inside

Since the last commit was on January 19 2019 and the latest Devices package from Facebook is from November 16 2018, I think the only cause of this may be new version of image magick?

milhauscz commented 5 years ago

Regarding the "new devices", they are not new, just the binary files were slightly modified, but resulting in the same image and file size.

janpio commented 5 years ago

Regarding the "new devices", they are not new, just the binary files were slightly modified, but resulting in the same image and file size.

Seems I am not able to read GitHub diffs today. Thanks and sorry.

v-kolesnikov commented 5 years ago

Hi @milhauscz and @janpio ! What the current status of this PR? I'm looking forward for these changes. Can I help you guys by something?

milhauscz commented 4 years ago

Hi @milhauscz and @janpio ! What the current status of this PR? I'm looking forward for these changes. Can I help you guys by something?

Currently everything is done on my side, frameit is working for both iOS and Android in a backward compatible way with the old frameit. I am waiting for the reviewers.

milhauscz commented 4 years ago

I've run the frames generator again and added all new devices from Facebook, see the commit message.

RicardoBelchior commented 4 years ago

@janpio @mollyIV is there any reason why this PR hasn't been merged ? everything looks fine...