search

fastmachinelearning / hls4ml

Machine learning on FPGAs using HLS
https://fastmachinelearning.org/hls4ml
Apache License 2.0
1.3k stars 419 forks source link

Update install_requires for 1.0.0 #1136

Closed vloncar closed 6 days ago

vloncar commented 6 days ago

Description

The current hls4ml won't install properly on an empty environment as this will pull TF 2.18 and keras v3 which are not compatible. We mention in the docs the supported versions of TF are between 2.8 and 2.14, but this was not enforced. Due to the restriction of TF 2.14 not working on python 3.12, we can only support python 3.10 and 3.11. Furthermore QKeras installation pulls version 0.9.0 which is not supported anymore. This was changed to the git version (we can put our own version if needed).

In the future once we move to a more modular base (beginnings of which are in #1094) we should also move to pyproject.toml for managing dependencies.

Type of change

Tests

Only concerns the environments. Shouldn't break existing test pipeline.

Checklist

yeah, yeah, I've done all of this.

bo3z commented 6 days ago

Looks good to me, just tested locally and it worked.