fatiando / boule

Reference ellipsoids for geodesy and geophysics
https://www.fatiando.org/boule
BSD 3-Clause "New" or "Revised" License
38 stars 17 forks source link

New ellipsoids #180

Closed MarkWieczorek closed 7 months ago

MarkWieczorek commented 8 months ago

The PR makes the following changes:

Vesta Notes

I removed the original VESTA triaxial ellipsoid because there is not enough information in the paper to determine the GM, it is not stated if the ellipsoid is geocentric or offset from the center of mass, and the directions of the principal axes are not given. I think that keeping this ellipsoid as is will just cause problems for people who use it. I wasted a lot of time trying to figure this one out (and never did). Instead, two new ellipsoids have been added: The default (Vesta2017) is biaxial, as Vesta has no real tides. The Vesta2017_triaxial ellispoid, in contrast, is triaxial. The triaxial one, however, is not aligned with the topography and gravity coordinate axes, and this is specified by the new attribute semimajor_axis_longitude.

All Ellipsoids

Mercury

Venus

Earth

Moon

Asteroids

Mars

Jupiter system

Saturn system

Pluto system

Relevant issues/PRs: Closes #176

MarkWieczorek commented 7 months ago

Please merge #183 and #185 first. Afterwards, I will make minor changes to this PR that make use of the new comments and semimajor_axis_longitude atrributes.

leouieda commented 7 months ago

Please note that all these ellipsoids are added to the main namespace. This might be too much of a mess for people, and I suggest that we instead put these all in a new module boule.ellipsoids. I will wait for your comments before doing so.

I think this is fine. The API itself is only 3 classes so having all of these in the main namespace is OK.