fatiando / harmonica

Forward modeling, inversion, and processing gravity and magnetic data
https://www.fatiando.org/harmonica
BSD 3-Clause "New" or "Revised" License
208 stars 68 forks source link

Forward model magnetic properties of prism_layer #399

Open markgrujic opened 1 year ago

markgrujic commented 1 year ago

Description of the desired feature:

There are certain scenarios where forward modelling the magnetic effect of layers is meaningful (e.g. topography). It seems that prism_layer can be used to define these layers and perhaps even assign magnetic properties, however there does not appear to be a mag equivalent to prism_gravity to perform the forward operation for the magnetic field. I can think of some things that would be needed, including:

Are you willing to help implement and maintain this feature?

Happy to help where I can, probably best suited to testing though!

santisoler commented 1 year ago

Hi @markgrujic! Thanks for opening this issue. We are aware that a lot of people will benefit from having forward modelling of magnetic fields in Harmonica (see https://github.com/orgs/fatiando/discussions/100 and https://github.com/orgs/fatiando/discussions/102).

The good news is that we are working on it. All the kernels for the magnetic fields of prisms and dipoles live in Choclo and I've started a PR for adding magnetic forward modelling functions for prisms (see #369).

I think @aguspesce will start working on adding a magnetic_field method to the prism layer accessor so we can easily compute the magnetic field of a layer of prisms.

We'll be glad if you would like to contribute! Is there anything that you would like to start working on?

aguspesce commented 1 year ago

Hello @santisoler and @markgrujic I will start to work on this today!

markgrujic commented 1 year ago

Aha, perfect! Makes sense to keep the kernels in choclo 🌽. I'll keep an eye on this and those linked discussions. Cheers