search

fatiando / pooch

A friend to fetch your data files
https://www.fatiando.org/pooch
Other
631 stars 76 forks source link

Support Dataverse files without a persistentID #355

Closed santisoler closed 9 months ago

santisoler commented 1 year ago

Add support for downloading Dataverse files that don't have a persistent ID. Use the file ID instead.

Relevant issues/PRs:

Fixes #354

TODO

santisoler commented 1 year ago

We should add some tests for this bugfix that downloads some file from a Dataverse repository that doesn't provide persistent ID for its files. I would avoid using preexisting repositories, we want very small files since these tests will be run multiple times. Creating a version of the test data for Pooch in another Dataverse repository would be nice.

leouieda commented 9 months ago

I can merge in main and make the changes since @santisoler is on vacation.

leouieda commented 9 months ago

Plus, finding a dataverse instance that doesn't have persistentIDs that would be willing to host the Pooch test data would be non-trivial. And they could always enable the PIDs and break our tests without any warning.

pdurbin commented 9 months ago

15f7536 looks like a nice simplification.

By the way we have a new changelog for breaking changes to the Dataverse API, which we hope to keep short! Here's how it looks as of Dataverse 6.1: https://guides.dataverse.org/en/6.1/api/changelog.html

leouieda commented 9 months ago

Thanks for sharing @pdurbin!