fatyogi / epever-upower-tracer

Linux/Raspberry monitoring scripts for EPsolar UPower hybrid invertors and EPever Tracer charge controllers
Apache License 2.0
29 stars 14 forks source link

Python 3 upgrade #2

Closed hrford closed 1 year ago

hrford commented 2 years ago

Python 2.7 is mentioned in the readme.md but Python 2.x is deprecated.

Update the documentation and/or convert to Python 3.x.

(As I use this project more, maybe I'll create a PR with the upgrade. Would that be fine?)

fatyogi commented 2 years ago

Hi Henry,

Sure go ahead with a PR. I am not actively developing this anymore as I don’t have the device.

Shall I make you a contributor on the project?

Cheers

On Mon, 25 Jul 2022 at 2:56 AM, Henry Ford @.***> wrote:

Python 2.7 is mentioned in the readme.md but Python 2.x is deprecated.

Update the documentation and/or convert to Python 3.x.

(As I use this project more, maybe I'll create a PR with the upgrade. Would that be fine?)

— Reply to this email directly, view it on GitHub https://github.com/fatyogi/epever-upower-tracer/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE4YYOZF5N5W2J4P3P7VLFLVVVKQLANCNFSM54PZD5UQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- // Laconic style, sent from my phone

hrford commented 2 years ago

yeah, that could be useful. I've got a pretty decent API based on your repo. Still building in all the functionality. Is there a scope you'd like me to keep to in your project?

UTC timestamp: 2022-07-25 13:40:09.548984 Settings BatteryType (0=USER): 0 BatteryCapacity, Ah : 100 TempCompensationCoeff, mV/°C/2V : 0 OverVoltageDisconnect : 14.7 ChargingLimitVoltage : 14.6 OverVoltageReconnect : 14.6 EqualizationVoltage : 14.4 BoostVoltage : 14.6 FloatVoltage : 13.6 BoostReconnectVoltage : 13.3 LowVoltageReconnect : 11.5 UnderVoltageRecover : 11.6 UnderVoltageWarning : 11.5 LowVoltageDisconnect : 11.0 DischargingLimitVoltage : 10.5 Temperature Limits Batt Hi temp limit : 65.0 Batt Lo temp limit : 615.36 Device over temp : 85.0 Device recovery temp : 75.0 Ratings Rated PV Voltage : 60 Rated PV Current : 20 Rated PV Power : 520 Rated Batt Voltage : 24 Rated Batt Current : 20 Rated Batt Power : 520 Rated Load Current : 20 Voltages PVvolt: 0 BAvolt: 13.14 DCvolt: 13.14 BAtemp: 20.42 BAperc: 82 BAstat: 0

fatyogi commented 2 years ago

Hi Henry,

That's all good, I added you as a collaborator. Thank you for working on that again.

There is no particular scope as such - if you see there are things that aren't working as claimed (for example the mass update of the parameters is a good catch - I was wondering why they do not get updated one by one?) - please feel free to fix those. Of course, if you are thinking of some features of the controller that could be utilised through the API - again, feel free to add them in.

At the moment I do not have the device to play with, so the whole thing is on hold for me. I may get one in the near future, and there we could collaborate further.

There is a bit of interest in this topic - whatever we do is going to be beneficial to a number of people out there, building their own solar systems.

On Tue, 26 Jul 2022 at 01:46, Henry Ford @.***> wrote:

yeah, that could be useful. I've got a pretty decent API based on your repo. Still building in all the functionality. Is there a scope you'd like me to keep to in your project?

UTC timestamp: 2022-07-25 13:40:09.548984 Settings BatteryType (0=USER): 0 BatteryCapacity, Ah : 100 TempCompensationCoeff, mV/°C/2V : 0 OverVoltageDisconnect : 14.7 ChargingLimitVoltage : 14.6 OverVoltageReconnect : 14.6 EqualizationVoltage : 14.4 BoostVoltage : 14.6 FloatVoltage : 13.6 BoostReconnectVoltage : 13.3 LowVoltageReconnect : 11.5 UnderVoltageRecover : 11.6 UnderVoltageWarning : 11.5 LowVoltageDisconnect : 11.0 DischargingLimitVoltage : 10.5 Temperature Limits Batt Hi temp limit : 65.0 Batt Lo temp limit : 615.36 Device over temp : 85.0 Device recovery temp : 75.0 Ratings Rated PV Voltage : 60 Rated PV Current : 20 Rated PV Power : 520 Rated Batt Voltage : 24 Rated Batt Current : 20 Rated Batt Power : 520 Rated Load Current : 20 Voltages PVvolt: 0 BAvolt: 13.14 DCvolt: 13.14 BAtemp: 20.42 BAperc: 82 BAstat: 0

— Reply to this email directly, view it on GitHub https://github.com/fatyogi/epever-upower-tracer/issues/2#issuecomment-1194068591, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE4YYOZSZMFC656M2ZKS44LVV2LE7ANCNFSM54PZD5UQ . You are receiving this because you commented.Message ID: @.***>

hrford commented 2 years ago

I've done a first pass and checked in code at https://github.com/fatyogi/epever-upower-tracer/tree/python-2-to-3 I'll need to regression test as much as possible before creating a PR

fatyogi commented 1 year ago

Thanks @hrford - I just added Python 3 support to the main branch. At least it works for the Tracer series.