search

favish / atom-drupal

Drupal snippets, filetypes and hotkeys for the Atom Editor
MIT License
28 stars 14 forks source link

Promise.done is deprecated. #15

Closed nvaken closed 8 years ago

nvaken commented 8 years ago

Atom now uses ES6 Promises instead of Q. Call promise.then instead of promise.done

Promise.done (/Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:1143:5)
Object.activate (/Users/nvaken/.atom/dev/packages/drupal/lib/drupal.coffee:6:22)
Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:183:20)
<unknown> (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:156:32)
Package.measure (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:92:15)
<unknown> (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:149:26)
robballou commented 8 years ago

Which version of Atom does this affect?

nvaken commented 8 years ago

That would be 1.9.8

robballou commented 8 years ago

I didn't get the warning myself, but I have applied a fix in the master branch if you want to test it out.

Thanks!

nvaken commented 8 years ago

I'm not sure when this was triggered, just saw it this one time. Since I'm unable to reproduce, I'll close it for now, fix seems legit to me.

jeffgeorge commented 7 years ago

@robballou I'm seeing this same warning in the Deprecation Cop in Atom 1.13.0-beta8. Can you please tag a new release with this fix included?

robballou commented 7 years ago

I don't think I can make new releases via APM, etc., but have tagged @michaelfavia who can.

michaelfavia commented 7 years ago

Release rolled and published. Testing it now. Thanks @robballou and @jeffgeorge!