search

favish / atom-drupal

Drupal snippets, filetypes and hotkeys for the Atom Editor
MIT License
28 stars 14 forks source link

Update grammar matcher for newer Atom editor #6

Closed jtwalters closed 9 years ago

jtwalters commented 9 years ago

The snippets weren't working since PHP is now text.html.php. I made the change and bumped the version to 2.0.0.

robballou commented 9 years ago

Looks good to me. I think we can get rid of the version bump because apm publish can handle that. Thanks for this update :)

jtwalters commented 9 years ago

I removed the version bump.

robballou commented 9 years ago

Out of curiosity, are you still seeing the PHP scope change? I think there was an issue with 0.197 that changed things but then 0.198 fixed it. If so I can roll this in (I still see source.php in the scopes for files).

michaelfavia commented 9 years ago

I tested our master just now and im not having any trouble with snippets in module files or install files. If there another file type that can reproduce the issue? That said i inspected the ATOM chromium dom and DID notice that the "data-grammar" attr is now "text html php".

I dont see any reason not to merge these changes as it seems more correct and still worked after i applied the PR. merging into master if rob signs off ill tag a release.

robballou commented 9 years ago

@michaelfavia @jtwalters works for me! :)

michaelfavia commented 9 years ago

New version pushed. Thank you all! @robballou and @jtwalters!

@robballou: should you want to in the future, you should be able to deploy new versions with apm as well.