fayaz12g / totk-aar

Any Aspect Ratio for Tears of the Kingdom! A tool to generate custom settings to make the game look great on any display!
109 stars 5 forks source link

Load/save stretching #63

Closed InterClaw closed 1 year ago

InterClaw commented 1 year ago

The changelog for 8.5.0 got me curious, so I spent some time comparing what it looks like when loading and saving the game in 8.4.1 and 8.5.0. I found some differences and things that don't look quite right. So I think that you're not quite done yet with these adjustments and that you know this? Nevertheless, I thought I'd share what I found, so perhaps it can help with further fixes around this! πŸ‘

I also realize this is a lot of nitpicking over dialogs you spend a few seconds at, but since you started down this path I let the OCD flow here. πŸ˜… Do with it as you please, hehe.

Below are the loading and saving processes in both 8.4.1 (left) and 8.5.0 (right). Saving has a few more steps it's going through pretty quickly, so I had to screen record and screenshot while pausing my video. All screenshots scaled down from 3840x1600 (2.4:1) to 50% and then cropped to the center 1000x800 pixels for comparison.

1. Loading

841-850-loading

a. List

b. Confirmation dialog

2. Saving

841-850-saving

a. Confirmation dialog

b. Saving... (1/3)

c. Saving... (2/3)

d. Progress saved (3/3)

Some closing comments:

fayaz12g commented 1 year ago

Hey! Thank you so so much for such a detailed report-- This was one of the biggest reasons I added you to the credits last night, you always do a great job testing and documenting issues :) Sorry I didn't respond sooner, I have an issue where if I plan too much of what to do or respond with, I never respond or push out changes, but I'm working on it.

You are correct, the saving screen is a giant WIP, but I can say almost all of it is complete now and pushed to the latest version! Here what I fixed: unknown_2023 08 07-14 49

Text is no longer squished in the preview, and the aspect ratio of the image is now correct to match the game. The buttons and text elements are all in line as well, in their correct positions.

unknown_2023 08 07-14 49_1 unknown_2023 08 07-14 49_2

The saving text has been fixed as well as the Progress Saved text. Here is what I need to work on: unknown_2023 08 07-14 48_1

The SystemLoadList shows the game previews in their correct ratios, but the text elements and autosave icon are stretched with it. For some reason, the game has this all as one block and I'm not sure where it pulls it from, but I will keep looking! Let me know if you find anything else that looks off!

InterClaw commented 1 year ago

Tried it all out now again in version 8.6.5!

The aspect ratio in the load list does look correct. And as you say the text is stretched.

One interesting thing about this though is that the thumbnail viewport seems to be cropped down to 3:1. The top and bottom pixels are not showing in the screenshot. Since there are no UI elements in these screenshots/thumbnails, you don't really notice. But what you do get to see, seems to have the right proportions at least.

865 load 1

I compared it to a regular screenshot of the game world with the camera in the same position...

865 world

... and then center cropped that screenshot from 3840x1600 down to 3840x1280. To me it looks spot on to what I'm seeing in the thumbnails. Sans the UI.

865 world 3to1

I guess they crop even regular 16:9 thumbnails this way to make them look more "cinematic" in the list perhaps. πŸ˜ƒ It is what it is.

I do however see something wrong in the confirmation dialogs (looks the same for both save and load).

865 load 2

There is some extra space to the left seemingly. And the thumbnail viewport is here approx. 2.85:1.

But I don't think what is showing is squished or stretched. Instead I think the same screenshot is here cropped differently. Comparing to the 3:1 screenshot above I do see more at the bottom of the picture. So it crops the same amount at the top, but "not enough" at the bottom, to get the same 3:1 thumbnail. πŸ˜ƒ

Actually, if the thumbnail was to extend into the extra space on the left AND the equivalent amount on the right, then you'd arrive at that same 3:1 ratio. Here's a screenshot from GIMP to show you what I mean. The ratio of the selection showing in the status bar bottom left. So if it was to "zoom in" a bit more, losing pixels at the bottom, to fill that 3:1 space, then it would look the same as in the load list.

865 confirmation 3to1

Beyond that, the overlay text and that animated icon look nice now! And the transition when the thumbnail goes away looks the same as the confirmation screen.

fayaz12g commented 1 year ago

I've made some changes to reduce that black space next to the box holding the image, hopefully that looks better

InterClaw commented 1 year ago

Tried it out not in 9.0.5. Definitely a lot better! It fills out the black space now. The confirmation is still 2.85:1, so it's cropped differently than the list that is 3:1. But these are dialogs you spend a few seconds at, so you're never gonna notice. πŸ‘