search

faye / faye-websocket-node

Standards-compliant WebSocket client and server
Other
610 stars 102 forks source link

SSL Pinning with Faye Websockets #75

Open ashenwgt opened 5 years ago

ashenwgt commented 5 years ago

I am aware that many websocket libraries in the client-side use faye-websockets to make use of its standards-compliant websocket behaviour. However, those libraries cannot be used to implement SSL pinning (e.g. sockjs-client). Is there any chance that users can implement SSL pinning with faye-websockets? If there is no such official approach, could you please provide any advise for developing such functionality for websockets?

jcoglan commented 4 years ago

@ashenwgt Could you explain to me what SSL pinning is and what kind of functionality you're looking for? It would help me to understand what changes might be necessary for us to support this.

jcoglan commented 4 years ago

I would add that the Client class does accept a tls option, which is passed directly through to the Node tls.connect() function. See here: https://github.com/faye/faye-websocket-node#initialization-options

So, any options Node's tls module supports are also supported by our Client class.