search

fbergmann / libSEDML

SED-ML library based on libSBML
BSD 2-Clause "Simplified" License
9 stars 12 forks source link

Fix and test sorting. #114

Closed luciansmith closed 3 years ago

luciansmith commented 3 years ago

Fixes https://github.com/fbergmann/libSEDML/issues/112 : the default return value of a sort comparator should be false, not true.

Also, add some 'normal' tests for sortOrderedObjects.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

luciansmith commented 3 years ago

I don't have plans for any more code commits, so after the existing PRs are resolved, a new pypi release would be great, yes. Thank you!