search

fbergmann / libSEDML

SED-ML library based on libSBML
BSD 2-Clause "Simplified" License
9 stars 12 forks source link

L1v4: need to implement change: SedLine / SedMarker attribute names were renamed from 'style' to 'type' #96

Closed luciansmith closed 3 years ago

luciansmith commented 3 years ago

Libsedml thinks that the types of a line and a marker are set in the attribute 'style', but should be 'type'.

fbergmann commented 3 years ago

This was a recent change in the last draft, before it was just 'marker', 'line' and such, which caused conflicts and inconsistencies (#67). The sed-ml generated should be fine though. Do you need this to change urgently? This would break the opencor implementation, right @agarny ?

luciansmith commented 3 years ago

No, it affects the SED-ML. libsedml produces:

<line style="dashDot" color="#FF00FF" thickness="4"/>

when it should produce:

<line type="dashDot" color="#FF00FF" thickness="4"/>

I dunno how urgent this is; it creates incorrect/invalid SED-ML, but it still demonstrates proof of concept.

fbergmann commented 3 years ago

yup that needs doing

agarny commented 3 years ago

This was a recent change in the last draft, before it was just 'marker', 'line' and such, which caused conflicts and inconsistencies (#67). The sed-ml generated should be fine though. Do you need this to change urgently? This would break the opencor implementation, right @agarny ?

When it comes to L1V4, it's still in a special branch of OpenCOR. So, we can change whatever we need to change, this won't break the current version of OpenCOR (which uses annotations for lines, markers, etc.).

fbergmann commented 3 years ago

this is now in the release 2.0.18, i hope it works for all. thanks @luciansmith